-
Notifications
You must be signed in to change notification settings - Fork 766
Fix the psushow error message on platform without psu at all #4151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuazhe
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
yuazhe:master_fix_psushow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
df76afc to
db2cb49
Compare
stephenxs
approved these changes
Dec 8, 2025
db2cb49 to
10d6898
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yuanzhe Liu <[email protected]>
10d6898 to
cdb6fd6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Dec 16, 2025
Collaborator
|
It is not clear to me how to ensure that the system is not expected to have PSU. Can you elaborate? |
ganglyu
previously approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
de-escalate the message when no psu had been detected at all from error to more moderate info.
How I did it
simply change the print output and remove the redundance ones
How to verify it
UT as well as manual test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
PSU not detected